Re: Enhance pg_stat_wal_receiver view to display connected host - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Enhance pg_stat_wal_receiver view to display connected host
Date
Msg-id 20180105121536.gdoiui7qaiprinve@alvherre.pgsql
Whole thread Raw
In response to Re: Enhance pg_stat_wal_receiver view to display connected host  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: Enhance pg_stat_wal_receiver view to display connected host
Re: Enhance pg_stat_wal_receiver view to display connected host
List pgsql-hackers
Haribabu Kommi wrote:

> And also not returning "default host" details, because for the conninfo
> without any host details, the return value must be NULL. But this change
> may break the backward compatibility of the function.

I wouldn't want to have to fight that battle.

> or
> 
> write two new functions PQconnhost() and PQconnhostaddr() to return the
> connected host and hostaddr and reuse the PQport() function.

How about using an API similar to PQconninfo, where we return an array
of connection options used?  Say, PQeffectiveConninfo().  This seems to
me to reduce ugliness in the API, and be more generally useful.

walrecvr could display as an array or just flatten to a string -- not
sure what's the better option there.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: [HACKERS] UPDATE of partition key
Next
From: Robert Haas
Date:
Subject: Re: [Patch] Make block and file size for WAL and relations defined atcluster creation