Re: [HACKERS] [PATCH] Lockable views - Mailing list pgsql-hackers

From Yugo Nagata
Subject Re: [HACKERS] [PATCH] Lockable views
Date
Msg-id 20171231195713.660dbeaa.nagata@sraoss.co.jp
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Lockable views  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: [HACKERS] [PATCH] Lockable views  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Hi,

The updated patch is attached.

On Fri, 29 Dec 2017 23:39:39 +0900 (JST)
Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

 
> The patch produces a warning.
> 
> /home/t-ishii/lock_view-v3.patch:542: trailing whitespace.
> -- Verify that we  can lock a auto-updatable views 
> warning: 1 line adds whitespace errors.

Fixed.

> 
> Your addition to the doc:
> +   Automatically updatable views (see <xref linkend="sql-createview">)
> +   that do not have <literal>INSTEAD OF</> triggers or <literal>INSTEAD</>
> +   rules are also lockable. When a view is locked, its base relations are
> +   also locked recursively with the same lock mode.
> 
> does not mention about the point:
> 
> >> >> > 1) Leave as it is (ignore tables appearing in a subquery)

I added this point to the documentation.


Regards,

> 
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp


-- 
Yugo Nagata <nagata@sraoss.co.jp>

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Why standby restores some WALs many times from archive?
Next
From: Magnus Hagander
Date:
Subject: Re: Logical decoding fast-forward and slot advance