Re: [HACKERS] pgbench - use enum for meta commands - Mailing list pgsql-hackers

From Aleksandr Parfenov
Subject Re: [HACKERS] pgbench - use enum for meta commands
Date
Msg-id 20171102142918.1328.12179.pgcf@coridan.postgresql.org
Whole thread Raw
In response to [HACKERS] pgbench - use enum for meta commands  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] pgbench - use enum for meta commands  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi,

Looks good to me.

The only thing I'm not quite sure about is a comment "which meta command ...".
Maybe it's better to write it without question word, something like "meta command identifier..."?

The new status of this patch is: Ready for Committer

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] ArrayLists instead of List (for some things)
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] ArrayLists instead of List (for some things)