[HACKERS] Why are we including netinet/tcp.h so widely? - Mailing list pgsql-hackers

From Andres Freund
Subject [HACKERS] Why are we including netinet/tcp.h so widely?
Date
Msg-id 20170929222444.iybcyvfv6grw4wia@alap3.anarazel.de
Whole thread Raw
Responses Re: [HACKERS] Why are we including netinet/tcp.h so widely?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

A lot of files which currently include netinet/tcp.h. For most of them I
cannot recognize why, and it just seems to have been copied from one
file to the next.

E.g.
src/interfaces/libpq/{fe-secure,fe-protocol3,fe-protocol2,fe-secure}.c
src/backend/libpq/{be-secure,be-secure-openssl}.c
and probably some more.

Not that it's particularly harmful to include a superflous include, but
due to the #ifdef HAVE_NETINET_TCP_H it's three lines, and it seems to
be copied enough that I got curious.

Any reason that I'm missing? Old platforms? I couldn't find anything in
the archives.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] pgbench - minor fix for meta command only scripts
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Parallel Append implementation