The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed
Hi,
I like the SP-GiST part of the patch. Looking forward to it, so PostGIS can benefit from SP-GiST infrastructure.
I have some questions about the circles example though.
* What is the reason for isnan check and swap of box ordinates for circle? It wasn't in the code previously.* There are
testsfor infinities in circles, but checks are for NaNs.* It seems to me that circle can be implemented without
recheck,by making direct exact calculations.
How about removing circle from the scope of this patch, so it is smaller and cleaner?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
