Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Log LDAP "diagnostic messages"? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] Log LDAP "diagnostic messages"?
Date
Msg-id 20170914141205.eup4kxzlkagtmfac@alvherre.pgsql
Whole thread Raw
In response to Re: [HACKERS] Log LDAP "diagnostic messages"?  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] Log LDAP "diagnostic messages"?  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Re: [HACKERS] Log LDAP "diagnostic messages"?  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
I think the ldap_unbind() changes should be in a separate preliminary
patch to be committed separately and backpatched.

The other bits looks fine, with nitpicks

1. please move the new support function to the bottom of the section
dedicated to LDAP, and include a prototype

2. please wrap lines longer than 80 chars, other than error message
strings.  (I don't know why this file plays fast & loose with
project-wide line length rules, but I also see no reason to continue
doing it.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [HACKERS] Parallel Hash take II
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] PATCH : Generational memory allocator (was PATCH: twoslab-like memory allocators)