Re: [HACKERS] Automatic testing of patches in commit fest - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [HACKERS] Automatic testing of patches in commit fest
Date
Msg-id 20170911130124.GC581@e733.localdomain
Whole thread Raw
In response to Re: [HACKERS] Automatic testing of patches in commit fest  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: [HACKERS] Automatic testing of patches in commit fest  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Hi Tomas,

> > Unless there are any objections to give this idea a try I'm willing to
> > write and host a corresponding script.
> >
> That won't work until (2) is reliable enough. There are patches (for
> example my "multivariate MCV lists and histograms") which fails to apply
> only because the tool picks the wrong patch. Possibly because it does
> not recognize compressed patches, or something.

Agree. However we could simply add an "Enable autotests" checkbox to the
commitfest application. In fact we could even left the commitfest
application as is and provide corresponding checkboxes in the web
interface of the "autoreviewer" application. Naturally every
automatically generated code review will include a link that disables
autotests for this particular commitfest entry.

I hope this observation will change your mind :)

--
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: [HACKERS] Add support for tuple routing to foreign partitions
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Parallel Append implementation