Re: [HACKERS] Regression stoping PostgreSQL 9.4.13 if a walsender is running - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Regression stoping PostgreSQL 9.4.13 if a walsender is running
Date
Msg-id 20170824222235.qflyaobzws25mrgh@alap3.anarazel.de
Whole thread Raw
In response to [HACKERS] Regression stoping PostgreSQL 9.4.13 if a walsender is running  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
List pgsql-hackers
Hi,

On 2017-08-22 19:28:22 +0200, Marco Nenciarini wrote:
> I have noticed that after the 9.4.13 release PostgreSQL reliably fails
> to shutdown with smart and fast method if there is a running walsender.
> 
> The postmaster continues waiting forever for the walsender termination.
> 
> It works perfectly with all the other major releases.
> 
> I bisected the issue to commit 1cdc0ab9c180222a94e1ea11402e728688ddc37d
> 
> After some investigation I discovered that the instruction that sets
> got_SIGUSR2 was lost during the backpatch in the WalSndLastCycleHandler
> function.
> 
> The trivial patch is the following:

Pushed, thanks!  And sorry again.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] taking stdbool.h into use
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] MCXT_ALLOC_NO_OOM -> DSA_ALLOC_NO_OOM in dsa.c