Re: [HACKERS] Preliminary results for proposed new pgindentimplementation - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Preliminary results for proposed new pgindentimplementation
Date
Msg-id 20170616174430.GQ11450@momjian.us
Whole thread Raw
In response to Re: [HACKERS] Preliminary results for proposed new pgindent implementation  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Preliminary results for proposed new pgindentimplementation  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Jun 16, 2017 at 01:34:01PM -0400, Tom Lane wrote:
> > I could live with both of these proposed
> > changes, the selection of the changes you posted looks like it could be
> > improved by code changes, but that's obviously a large amount of work.
> 
> In the end, the only thing that fixes this sort of stuff is to be more
> rigid about making the code fit into 80 columns to begin with.  I get
> the impression though that a lot of people work in editor windows that
> are wider than that, so the code looks fine to them when it slops over
> a bit.

Yes, it is all about <80 column output.  The current pgindent does
everything possible to accomplish that --- the question is whether we
want uglier code to do it.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] Making server name part of the startup message