Re: [HACKERS] make check false success - Mailing list pgsql-hackers

From Sandro Santilli
Subject Re: [HACKERS] make check false success
Date
Msg-id 20170605092357.4b6ejmbnt2imliaw@liz
Whole thread Raw
In response to Re: [HACKERS] make check false success  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] make check false success  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] make check false success  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Jun 02, 2017 at 08:20:25AM -0400, Robert Haas wrote:
> On Thu, Jun 1, 2017 at 10:18 AM, Sandro Santilli <strk@kbt.io> wrote:
> > I noticed that the `check` Makefile rule imported by PGXS is giving
> > a success exit code even when it is unsupported.
> >
> > The attached patch fixes that.
> 
> Hmm.  I'm not 100% sure that the existing behavior is wrong.

Why not ? The caller is attempting to make an unsupported target,
how's that different from calling `make unexistent` ?

--strk;



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [HACKERS] Challenges preventing us moving to 64 bit transactionid (XID)?
Next
From: Etsuro Fujita
Date:
Subject: Re: [HACKERS] Bug in ExecModifyTable function and trigger issues forforeign tables