Re: [HACKERS] snapbuild woes - Mailing list pgsql-hackers

From andres@anarazel.de (Andres Freund)
Subject Re: [HACKERS] snapbuild woes
Date
Msg-id 20170511215155.bnigoevqoe4hejmg@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] snapbuild woes  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] snapbuild woes  (Peter Geoghegan <pg@bowt.ie>)
Re: [HACKERS] snapbuild woes  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2017-05-08 00:10:12 -0700, Andres Freund wrote:
> I plan to commit the next pending patch after the back branch releases
> are cut - it's an invasive fix and the issue doesn't cause corruption
> "just" slow slot creation. So it seems better to wait for a few days,
> rather than hurry it into the release.

Now that that's done, here's an updated version of that patch.  Note the
new logic to trigger xl_running_xact's to be logged at the right spot.
Works well in my testing.

I plan to commit this fairly soon, unless somebody wants a bit more time
to look into it.

Unless somebody protests, I'd like to slightly revise how the on-disk
snapshots are stored on master - given the issues this bug/commit showed
with the current method - but I can see one could argue that that should
rather be done next release.

- Andres



pgsql-hackers by date:

Previous
From: Yaroslav
Date:
Subject: Re: [HACKERS] CTE inlining
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] snapbuild woes