Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] PG_GETARG_GISTENTRY? - Mailing list pgsql-hackers

From Noah Misch
Subject Re: [HACKERS] PG_GETARG_GISTENTRY?
Date
Msg-id 20170425011052.GA270877@rfd.leadboat.com
Whole thread Raw
In response to Re: [HACKERS] PG_GETARG_GISTENTRY?  (Mark Dilger <hornschnorter@gmail.com>)
Responses [HACKERS] Use PG_DETOAST_DATUM_SLICE in bitlength() (was Re:PG_GETARG_GISTENTRY?)  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
On Mon, Apr 24, 2017 at 09:25:25AM -0700, Mark Dilger wrote:
> Here is a small patch for the next open commitfest which handles a case
> that Noah's commits 9d7726c2ba06b932f791f2d0cc5acf73cc0b4dca and
> 3a0d473192b2045cbaf997df8437e7762d34f3ba apparently missed.

The scope for those commits was wrappers of PG_DETOAST_DATUM_PACKED(), which
does not include PG_DETOAST_DATUM_SLICE().

> Noah, if you left this case out intentionally, sorry for the noise.  I did not
> immediately see any reason not to follow your lead for this function.

This is not following my lead, but that doesn't make it bad.  It's just a
different topic.

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: [HACKERS] warning in twophase.c
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] some review comments on logical rep code