Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pgbench - allow to store select results intovariables - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: [HACKERS] pgbench - allow to store select results intovariables
Date
Msg-id 20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: [HACKERS] pgbench - allow to store select results intovariables  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] pgbench - allow to store select results intovariables  (Fabien COELHO <coelho@cri.ensmp.fr>)
Re: [HACKERS] pgbench - allow to store select results into variables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
> Hello,
> 
>> I think you'd better to change the following comments because there's
>> no psqlscan.l or psqlscanslash.l in pgbench source tree.
>>
>> + * underscore.  Keep this in sync with the definition of
>> variable_char in
>> + * psqlscan.l and psqlscanslash.l.
> 
> Here is a v3 with a more precise comment.

Looks good to me. I have marked the patch status as "Ready for
committer".

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] DROP SUBSCRIPTION, query cancellations and slot handling
Next
From: Paresh More
Date:
Subject: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL