Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Reversed sync check in pg_receivewal - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [HACKERS] Reversed sync check in pg_receivewal
Date
Msg-id 20170411132808.GD9058@e733.localdomain
Whole thread Raw
In response to [HACKERS] Reversed sync check in pg_receivewal  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Hi Magnus,

> Attached patch reverses the check, and adds a failure message. I'd
> appreciate a quick review in case I have the logic backwards in my head...

Well, I can state that `make check-world` passes on my laptop and that
code seems to be right. However documentation to WalWriteMethod could
probably be improved. Currently there is none.

--
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Reversed sync check in pg_receivewal
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] Reversed sync check in pg_receivewal