Re: partitioned tables and contrib/sepgsql - Mailing list pgsql-hackers

From Andres Freund
Subject Re: partitioned tables and contrib/sepgsql
Date
Msg-id 20170405145354.22qnvqgywjnowkw2@alap3.anarazel.de
Whole thread Raw
In response to Re: partitioned tables and contrib/sepgsql  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: partitioned tables and contrib/sepgsql  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2017-04-05 10:48:27 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2017-03-31 20:23:39 -0400, Robert Haas wrote:
> >> 0001 has the problem that we have a firm rule against putting any
> >> #includes whatsoever before "postgres.h".  This stdbool issue has come
> >> up before, though, and I fear we're going to need to do something
> >> about it.
> 
> > I think in this case it makes sense to deviate from that rule,
> > temporarily and locally.
> 
> I'd really rather not.  It might be safe here, because this code
> only works on Linux anyway, but it's still a dangerous precedent.

Well, what's the alternative for v10?  There's already precedent btw.,
cf plperl.h undefining bool.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: partitioned tables and contrib/sepgsql
Next
From: Andres Freund
Date:
Subject: Re: Rewriting the test of pg_upgrade as a TAP test