Re: [PATCH] Reduce src/test/recovery verbosity - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [PATCH] Reduce src/test/recovery verbosity
Date
Msg-id 20170330202919.GY9812@tamriel.snowman.net
Whole thread Raw
In response to Re: [PATCH] Reduce src/test/recovery verbosity  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Reduce src/test/recovery verbosity  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
Tom, all,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > I'd be fine with removing --verbose globally, as your patch does, but
> > there was some argument that we then would have long 'quiet' periods.
> > I haven't had a chance to go test if that's really the case yet though.
>
> I've been running it like this lately:
>
> make -s check-world -j4 PROVE_FLAGS='-j4 --quiet --nocolor --nocount'
>
> and it is still pretty noisy ;-).  The only place where it sits for
> more than a couple of seconds without printing anything is at the very
> start, which I believe to be the initial "make temp-install" step,
> which would be unaffected by prove verbosity anyway.
>
> So I'd be +1 for just removing --verbose by default.  Anybody who really
> wants it can put it back via PROVE_FLAGS.

Yeah, I'm feeling the same way on this, and it'd reduce the size of the
logs on the buildfarm too, which I believe is a good thing.

Unless people wish to object, I'll use Michael's patch to remove
--verbose from the top level tomorrow.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Default monitoring roles
Next
From: Kuntal Ghosh
Date:
Subject: Re: strange parallel query behavior after OOM crashes