Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support
Date
Msg-id 20170312195230.GX9812@tamriel.snowman.net
Whole thread Raw
In response to Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support  (Stephen Frost <sfrost@snowman.net>)
Responses Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
Greetings,

* Stephen Frost (sfrost@snowman.net) wrote:
> * Stephen Frost (sfrost@snowman.net) wrote:
> > * Haribabu Kommi (kommi.haribabu@gmail.com) wrote:
> > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy <vitaly.burovoy@gmail.com> wrote:
> > > > The new status of this patch is: Ready for Committer
> > >
> > > Thanks for the review.
> >
> > I've started taking a look at this with an eye towards committing it
> > soon.
>
> I've spent a good bit of time going over this, possibly even more than
> it was worth, but hopefully we'll see people making use of this data
> type with PG10 and as more IPv6 deployment happens.

And, naturally, re-reading the email as it hit the list made me realize
that the documentation/error-message incorrectly said "3rd and 4th"
bytes were being set to FF and FE, when it's actually the 4th and 5th
byte.  The code was correct, just the documentation and the error
message had the wrong numbers.  The commit message is also correct.

As a reminder to myself, this will also need a catversion bump when it
gets committed, of course.

Updated patch attached.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: [HACKERS] bugfix: xpath encoding issue
Next
From: Noah Misch
Date:
Subject: Re: [HACKERS] possible encoding issues with libxml2 functions