Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to bePGDLLIMPORT'ified. - Mailing list pgsql-committers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to bePGDLLIMPORT'ified.
Date
Msg-id 20170310040018.vcsp6rsh5baqngie@alap3.anarazel.de
Whole thread Raw
In response to [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
List pgsql-committers
On 2017-03-10 03:55:50 +0000, Tom Lane wrote:
> contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
>
> Per buildfarm.  Maybe some of the other xmin variables in snapmgr.h
> ought to get this too, but for the moment I'm just interested in
> un-breaking the buildfarm.

Heh, I just wanted to push a patch removing the assertion because it
doesn't add that much.  There's imo no reason not to mark the variable
PGDLLIMPORT, so I'm good with this too.

- Andres


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
Next
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: amcheck: editorialize variable name & comment.