Re: [COMMITTERS] pgsql: Fix pgbench's failure to honor thedocumented long-form option " - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: [COMMITTERS] pgsql: Fix pgbench's failure to honor thedocumented long-form option "
Date
Msg-id 20170310030932.b762pstg6cosw7xc@alvherre.pgsql
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Fix pgbench's failure to honor the documentedlong-form option "  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-committers
Fabien COELHO wrote:
>
> > Not only did it not accept --builtin as a synonym for -b, but what it did
> > accept as a synonym was --tpc-b (huh?), which it got even further wrong
> > by marking as no_argument, so that if you did try that you got a core
> > dump.  I suppose this is leftover from some early design for the new
> > switches added by commit 8bea3d221, but it's still pretty sloppy work.
>
> Argh, shame on me. I think at some point --tpc-b was an alias for the
> default script which then got replaced by builtin + name, but the
> implementation did not follow the upgrade:-( Sorry for the result.

Ouch, this is terrible.  I was so focused on the actual feature that I
forgot to verify that the UI was sane.  I know I only tested using -b ...

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: Create INSTALL file via XSLT
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix hard-coded relkind constants in assorted src/bin files.