Re: [HACKERS] Patch to implement pg_current_logfile() function - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] Patch to implement pg_current_logfile() function
Date
Msg-id 20170120131145.lk4lg4mohqhtwhoc@alvherre.pgsql
Whole thread Raw
In response to Re: [HACKERS] Patch to implement pg_current_logfile() function  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
> diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c

> @@ -148,6 +149,9 @@ static const char *excludeFiles[] =
>      /* Skip auto conf temporary file. */
>      PG_AUTOCONF_FILENAME ".tmp",
>  
> +    /* Skip current log file temporary file */
> +    LOG_METAINFO_DATAFILE_TMP,
> +

Sorry if this has already been answered, but why are we not also
skipping LOG_METAINFO_DATAFILE itself?  I can't see a scenario where
it's useful to have that file in a base backup, since it's very likely
that the log file used when the backup is restored will be different.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: [HACKERS] Valgrind-detected bug in partitioning code
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Patch to implement pg_current_logfile() function