Re: [COMMITTERS] pgsql: Add function to import operating systemcollations - Mailing list pgsql-committers

From Stephen Frost
Subject Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Date
Msg-id 20170119170331.GU18360@tamriel.snowman.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add function to import operating system collations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> WFM.  Btw, I noticed that BOOTSTRAP_SUPERUSERID is hard-coded as "10"
> >> in this bit in setup_privileges():
>
> > Hm.  I seem to recall trying to avoid having the hard-coded value there
> > but we don't have BOOTSTRAP_SUPERUSERID defined somewhere that initdb.c
> > could include it from, do we?  It's only in catalog/pg_authid.h.
>
> Looks to me like including catalog/pg_authid.h in initdb would work fine.
> pg_upgrade does it.

Ah, alright then.  I'm happy to let whomever make that change, or, if no
one else wants to, I'll do it since I'm the author of those lines.

Thanks!

Stephen

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Add function to import operating system collations
Next
From: Stephen Frost
Date:
Subject: [COMMITTERS] pgsql: Dump sequence data based on the TableDataInfo flag