Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin
Date
Msg-id 20170109193303.txhqsclrtuhc2hfo@alvherre.pgsql
Whole thread Raw
In response to Incorrect XLogRegisterBuffer flag for revmapbuf in brin  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
Responses Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Kuntal Ghosh wrote:
> Hi all,
> 
> In brin_doupdate(line 290), REGBUF_STANDARD is used to register
> revmap buffer reference in WAL record. But, revmap buffer page doesn't
> have a standard page layout and it doesn't update pd_upper and
> pd_lower as well.

Hmm.  This bug should be causing WAL replay to zero out the revmap page
contents, since essentially the whole page is covered by the "hole" in
standard pages.  I can't see what is causing that not to happen, but
evidently it isn't, since the index works in a replica.  What am I
missing?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Increase pltcl test coverage
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE