Re: Updates of SE-PostgreSQL 8.4devel patches (r1197) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)
Date
Msg-id 20169.1227024473@sss.pgh.pa.us
Whole thread Raw
In response to Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)  (KaiGai Kohei <kaigai@ak.jp.nec.com>)
Responses Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)  (KaiGai Kohei <kaigai@kaigai.gr.jp>)
Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
KaiGai Kohei <kaigai@ak.jp.nec.com> writes:
> I'll try your approash in first, as follows:

This seems a vast amount of uglification to avoid adding an argument to
CreateTemplateTupleDesc.  We do that kind of thing all the time --- it
is a simple and reliable change to make.

When designing a patch, you should generally try to make the code look
like the patch has been there all along.  Contorting logic to avoid
a simple API change is not good.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Sam Mason
Date:
Subject: Re: is any reason why only one columns subselect are allowed in array()?
Next
From: Zdenek Kotala
Date:
Subject: Re: Re: toast by chunk-end (was Re: PG_PAGE_LAYOUT_VERSION 5 - time for change)