Re: [BUGS] BUG #14468: One byte buffer overlow inquote_literal_cstr() - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: [BUGS] BUG #14468: One byte buffer overlow inquote_literal_cstr()
Date
Msg-id 20161216144351.apdbuk4je5ywekle@alvherre.pgsql
Whole thread Raw
In response to [BUGS] BUG #14468: One byte buffer overlow in quote_literal_cstr()  (hlinnaka@iki.fi)
List pgsql-bugs
hlinnaka@iki.fi wrote:

> Looking at quote_literal_cstr(), it simply doesn't take into account the
> space needed for the NULL terminator, when it allocates the buffer. The fix
> is a straightforward + 1 to the allocation. I'll go and do that shortly, and
> backpatch.

Hm, that's a bit confusing.  I thought the +3 included the terminator,
but what it's actually for is the optional starting E; and the reason
quote_literal doesn't need similar patching it is that there is no
terminator 'cause it produces varlena.  I would think this deserves a
comment ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: hlinnaka@iki.fi
Date:
Subject: [BUGS] BUG #14468: One byte buffer overlow in quote_literal_cstr()
Next
From: Jeff Janes
Date:
Subject: Re: [BUGS] pg_dump's results have quite different size