Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests
Date
Msg-id 20161207134734.GH11146@e733.localdomain
Whole thread Raw
In response to [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
Hello, Craig.

I noticed that these patches have a "Needs review" status and decided to
take a look. Surprisingly I didn't manage to find many defects.

* I like this idea in general;
* Code is test covered and documented well;
* All tests pass;
* No warnings during compilation and/or tests run;
* I didn't find any typos;
* Code style seems to be OK;

Though are you sure you want to name a class like_this instead of LikeThis?
It's quite uncommon in Perl code and usually used only for packages like
"strict" and "warnings". However I prefer no to insist on changes like
this since it's a matter of taste.

The bottom line --- this code looks good to me. If there is nothing you
would like to change in the last moment I suggest to change the status
to "Ready for committer".

--
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: patch: function xmltable
Next
From: Kohei KaiGai
Date:
Subject: varlena beyond 1GB and matrix