Re: Broken SSL tests in master - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Broken SSL tests in master
Date
Msg-id 20161202023142.GA10293@paquier.xyz
Whole thread Raw
In response to Re: Broken SSL tests in master  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Broken SSL tests in master  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Dec 01, 2016 at 03:17:34PM -0500, Robert Haas wrote:
> It might be that (as suggested downthread) we should consider
> supporting multiple IPs in the hostaddr string as well, but that
> requires some thought.  For example, what happens if, for example, the
> host and hostaddr lists are of unequal length?  Would we accept one
> host and >1 hostaddrs?  Probably makes sense to just apply the host to
> every hostaddr.  >1 host and 1 hostaddr?  Probably doesn't make sense,
> but I guess you could argue for it.  Equal length lists definitely
> make sense.

That would make the current code a huge plate of spagetthi for sanity
checks considering the multiple interations between port, host and
hostaddr. It seems to me that the current approach of supporting only
port and host is simple enough and will satisfy most of the user's
need plently. So +1 for simplicity.
--
Michael

pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
Next
From: Peter Eisentraut
Date:
Subject: Re: DROP FUNCTION of multiple functions