Re: pg_dump / copy bugs with "big lines" ? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_dump / copy bugs with "big lines" ?
Date
Msg-id 20161128172840.o333bvq4z4brlfcj@alvherre.pgsql
Whole thread Raw
In response to Re: pg_dump / copy bugs with "big lines" ?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
I just wrote:

> The big advantage of your v3 patch is that it can be backpatched without
> fear of breaking ABI, so I've struggled to maintain that property in my
> changes.  We can further tweak in HEAD-only; for example change the API
> to use Size instead of int.  I think that would be desirable, but let's
> not do it until we have backpatched this one.

One thing I just noticed while trying to backpatch this is that we can
do so only to 9.5, because older branches do not have
MemoryContextAllocExtended().  They do have MemoryContextAllocHuge(),
but the caller in heaptuple.c wants zeroed memory too, so we'd need to
memset; I think that could get us back to 9.4.

9.3 and older is not possible because we don't have "huge alloc" there.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: HASH_CHUNK_SIZE vs malloc rounding
Next
From: Christian Convey
Date:
Subject: Re: Tackling JsonPath support