Re: pgsql: Properly indent postgresql.conf comments to align - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Properly indent postgresql.conf comments to align
Date
Msg-id 20161027123759.GA26821@momjian.us
Whole thread Raw
In response to Re: pgsql: Properly indent postgresql.conf comments to align  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Properly indent postgresql.conf comments to align
List pgsql-committers
On Wed, Oct 26, 2016 at 10:23:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Properly indent postgresql.conf comments to align
>
> I think "properly" here is very dependent on what you believe the
> tab width is.  While most of us have our editors set up for 4-space
> tabs in C files, I don't think all contributors do so for text files
> (I don't, for one).  And the odds that the average user will be set up
> to edit postgresql.conf with 4-space tabs are nil.
>
> I suggest that the best way out of this might be to detab
> postgresql.conf.sample entirely, and ditto for our other sample
> config files.  We could probably set up .gitattributes to make
> git complain if anyone re-introduces tabs into those files.

Uh, the postgresql.conf file is full of tabs, and they all assume
8-space tabs.  I was just making those few lines consistent.

Not sure we want to remove all tabs though.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Avoid using a C++ keyword in header file
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql: Properly indent postgresql.conf comments to align