Postgres Pro
Downloads
Home   >   mailing lists

pg_rewind: Should abort if both --source-pgdata and --source-server are specified - Mailing list pgsql-hackers

From Michael Banck
Subject pg_rewind: Should abort if both --source-pgdata and --source-server are specified
Date
Msg-id 20161007103414.GD12247@nighthawk.caipicrew.dd-dns.de
Whole thread Raw
Responses Re: pg_rewind: Should abort if both --source-pgdata and --source-server are specified  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
Hi,

ISTM that pg_rewind's --source-pgdata and --source-server options are
mutually exclusive, and the synopsis in the documentation seems to
indicate that as well:

|pg_rewind [option...] {-D | --target-pgdata} directory
|{--source-pgdata=directory | --source-server=connstr}

However, there is no such check in the code.

I've seen people assume --source-pgdata is supposed to be the data
directory location on the remote server if they specify --source-server
as well, and are then confused by error messages.

So I think pg_rewind should abort in this case.  Patch for that attached.

Thoughts?


Michael

--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: pg_stat_statements and non default search_path
Next
From: Heikki Linnakangas
Date:
Subject: Re: Radix tree for character conversion