Re: Remove superuser() checks from pgstattuple - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Remove superuser() checks from pgstattuple
Date
Msg-id 20160928153816.GV5148@tamriel.snowman.net
Whole thread Raw
In response to Re: Remove superuser() checks from pgstattuple  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael,

* Michael Paquier (michael.paquier@gmail.com) wrote:
> On Tue, Sep 27, 2016 at 4:43 AM, Stephen Frost <sfrost@snowman.net> wrote:
> > * Peter Eisentraut (peter.eisentraut@2ndquadrant.com) wrote:
> >> This is now being obsoleted by the later idea of allowing base installs
> >> from a chain of upgrade scripts.  But if your upgrade scripts contain
> >> ALTER TABLE commands, you will probably still want to write base install
> >> scripts that do a fresh CREATE TABLE instead.
> >
> > I've updated the patch to remove the new base version script and to rely
> > on the changes made by Tom to install the 1.4 version and then upgrade
> > to 1.5.
> >
> > Based on my testing, it appears to all work correctly.
>
> Same conclusion from here.

Fantastic, thanks for the testing!

> > Updated (much smaller) patch attached.
>
> I had a look at it, and it is doing the work it claims to do. So I am
> marking it as "Ready for Committer".

Great.  I'm going to go over the whole patch closely again and will push
it soon.

Thanks again!

Stephen

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: assert violation in logical messages serialization
Next
From: Robert Haas
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers