Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Date
Msg-id 20160908205803.GA60492@alvherre.pgsql
Whole thread Raw
In response to CVE-2016-1238 fix breaks (at least) pg_rewind tests  (Andres Freund <andres@anarazel.de>)
Responses Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund wrote:

> ISTM that the easiest fix is to just tack  -I '$(srcdir)' into the prove
> flags like:
> PROVE = @PROVE@
> PG_PROVE_FLAGS = -I $(top_srcdir)/src/test/perl/ -I '$(srcdir)'
> PROVE_FLAGS = --verbose
> 
> I don't think there's any security concerns for us here.

Maybe not, but we could just as well use -I$(top_srcdir)/src/test/perl
and not have to think about it.

But we have other .pm's ... are there other things that would break once
the fix for that problem propagates?  I think the msvc stuff will break,
for one.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Next
From: Andres Freund
Date:
Subject: Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests