Re: Missing checks when malloc returns NULL... - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Missing checks when malloc returns NULL...
Date
Msg-id 20160829130513.GA8340@e733
Whole thread Raw
In response to Re: Missing checks when malloc returns NULL...  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Missing checks when malloc returns NULL...  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Re: Missing checks when malloc returns NULL...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hello, Michael

> I don't know how you did it, but this email has visibly broken the
> original thread. Did you change the topic name?

I'm very sorry for this. I had no local copy of this thread. So I wrote a
new email with the same subject hoping it will be OK. Apparently right
In-Reply-To header is also required.

>   if (prodesc->user_proname == NULL || prodesc->internal_proname == NULL)
> + {
> +    free(prodesc);

I think that prodesc->user_proname and prodesc->internal_proname should
also be freed if they are not NULL's.

> By the way maybe someone knows other procedures besides malloc, realloc
> and strdup that require special attention?

I recalled that there is also calloc(). I've found four places that use
calloc() and look suspicious to me (see attachment). What do you think -
are these bugs or not?

--
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Renaming of pg_xlog and pg_clog
Next
From: "Daniel Verite"
Date:
Subject: Re: Renaming of pg_xlog and pg_clog