Re: PATCH: Exclude additional directories in pg_basebackup - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: PATCH: Exclude additional directories in pg_basebackup
Date
Msg-id 20160817163521.GA900783@alvherre.pgsql
Whole thread Raw
In response to Re: PATCH: Exclude additional directories in pg_basebackup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: PATCH: Exclude additional directories in pg_basebackup  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Robert Haas wrote:

> Eh ... I doubt very much that it's safe to blow away the entire
> contents of an SLRU between shutdown and startup, even if the data is
> technically transient data that won't be needed again after the system
> is reset.

Hmm.  At least async.c (pg_notify) deletes the whole directory at
startup so it's fine, but for the others (pg_serial, pg_subtrans) I
think it'd be saner to keep any "active" files (probably just the
latest).  I don't remember how pg_snapshot works, but it's probably fine
to start with an empty subdir (is it possible to export a snapshot from
a prepared transaction?)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: drop src/backend/port/darwin/system.c ?
Next
From: Gavin Flower
Date:
Subject: Re: [GENERAL] C++ port of Postgres