Tom Lane wrote:
> While researching a pgsql-general question, I noticed that commit
> 73c986adde5d73a5e2555da9b5c8facedb146dcd added several new fields
> to pg_control without bothering to touch PG_CONTROL_VERSION. Thus,
> PG_CONTROL_VERSION is still "942" even though the file contents
> are not at all compatible with 9.4.
Oh crap :-(
> It's way too late to do anything about this in 9.5. I wonder though
> if we should advance PG_CONTROL_VERSION now, presumably to "960",
> so that at least as of 9.6 the format is correctly distinguished
> from the 9.4-era format. Or will that just make things even more
> confusing, given that 9.5 is what it is?
I can't quite make up my mind about it. It seems pointless to change
it now, but at the same time it seems wrong to let it continue to be
unchanged from 9.4.
I slightly lean towards changing it in 9.6.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
