Re: Error during restore - dump taken with pg_dumpall -c option - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Error during restore - dump taken with pg_dumpall -c option
Date
Msg-id 20160525033308.GW21416@tamriel.snowman.net
Whole thread Raw
In response to Re: Error during restore - dump taken with pg_dumpall -c option  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers
Rushabh,

* Rushabh Lathia (rushabh.lathia@gmail.com) wrote:
> On Fri, May 13, 2016 at 7:27 PM, Stephen Frost <sfrost@snowman.net> wrote:
>
> > * Rushabh Lathia (rushabh.lathia@gmail.com) wrote:
> > > On master branch when we do pg_dumpall with -c option, I can see that
> > > it also dumping the "DROP ROLE pg_signal_backend", which seems wrong.
> > > Because when you restore the dump, its throwing an error
> > > "ERROR:  cannot drop role pg_signal_backend because it is required by the
> > > database system".
> >
> > Ah, yes, dropRoles() needs the same change that dumpRoles() got.
> >
> > Will fix, thanks!
>
> Thanks Stephen.

I've puhsed a fix for this.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: To-Do item: skip table scan for adding column with provable check constraints
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Parallel pg_dump's error reporting doesn't work worth squat