Re: pgindent - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pgindent
Date
Msg-id 20160427210114.GB6833@momjian.us
Whole thread Raw
In response to Re: pgindent  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgindent
List pgsql-hackers
On Wed, Apr 27, 2016 at 02:54:35PM -0400, Robert Haas wrote:
> On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> >> I think it's about time for us to run pgindent.  I did a trial run
> >> today of pgindent today and came up with the attached patch for
> >> typedefs.list, which I'd like to commit more or less immediately,
> >> barring objections.
> >
> > Um, we normally take the buildfarm's list of typedefs, not anything
> > manually created.
> 
> Well, we can still do that, but I don't see much advantage in it.  It
> just churns the file to the extent that manual review of the changes
> is impossible, and then when pgindent does the wrong thing it only
> gets reported after the fact.  How is that better than making sure
> that the contents of the file are such as to actually produce good
> output from pgindent?

Using the buildfarm typedefs assures they are always generated in a
consistent way.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.
Next
From: Stephen Frost
Date:
Subject: Re: Add jsonb_compact(...) for whitespace-free jsonb to text