* Noah Misch (noah@leadboat.com) wrote:
> On Thu, Apr 07, 2016 at 03:50:47PM -0400, Stephen Frost wrote:
> > I'm planning to continue going over the patch tomorrow morning with
> > plans to push this before the feature freeze deadline.
>
> > --- a/src/test/regress/expected/rolenames.out
> > +++ b/src/test/regress/expected/rolenames.out
>
> > +GRANT testrol0 TO pg_abc; -- error
> > +ERROR: role "pg_abc" is reserved
> > +DETAIL: Cannot GRANT roles to a reserved role.
>
> The server still accepts "ALTER ROLE testrol0 USER pg_signal_backend". It
> should block this ALTER ROLE if it blocks the corresponding GRANT.
Agreed, I specifically recall looking at that bit of code, but I think I
got myself convinced that it was the other way around (that the ALTER
would end up granting pg_signal_backend to testrol0, which would be
fine), but you're right, this needs to be prevented also.
Will fix.
Thanks!
Stephen
