Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
Date
Msg-id 20160415192737.GG10850@tamriel.snowman.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
List pgsql-hackers
* Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
> Stephen Frost wrote:
> > Alvaro,
>
> > Will take a look at this, though I'm just about to commit a fix that's
> > probably related (and addresses Pavel's issue).  Basically, for reasons
> > unknown, I was calling systable_endscan() immediately after
> > systable_getnext(), which doesn't work when you want to use the tuple
> > you got back.
>
> Yeah, I noticed that bug too.  It might well explain the issue, because
> the tuple is seen as 0x7f.
>
> #0  heap_deform_tuple (tuple=tuple@entry=0x339f438, tupleDesc=tupleDesc@entry=0x7f680f3dcde0,
>     values=values@entry=0x3390cd8,
>     isnull=isnull@entry=0x339f3c8 "\177\177\177\177\177~\177\177h\367\071\003")
>     at /pgsql/source/master/src/backend/access/common/heaptuple.c:881
> #1  0x0000000000479e3a in heap_modify_tuple (tuple=tuple@entry=0x339f438, tupleDesc=0x7f680f3dcde0,
>     replValues=replValues@entry=0x7ffd662a3770, replIsnull=replIsnull@entry=0x7ffd662a3750 "",
>     doReplace=doReplace@entry=0x7ffd662a3760 "")
>     at /pgsql/source/master/src/backend/access/common/heaptuple.c:817
> #2  0x0000000000518feb in recordExtensionInitPriv (objoid=46960, classoid=2615, objsubid=0,
>     new_acl=0x339f188) at /pgsql/source/master/src/backend/catalog/aclchk.c:5305
> #3  0x000000000051d2b5 in ExecGrant_Namespace (istmt=<optimized out>)
>     at /pgsql/source/master/src/backend/catalog/aclchk.c:2942
>
> Not sure what "Pavel's issue" is, since it's not listed in the open
> items page.

Here's the latest message ID on the thread he started.

CAFj8pRB_8WggxG1EKgfDQ_G_C1p1iLC_j9M3JfLfMLd2Vxt_+w@mail.gmail.com

Pretty sure it's the same issue.  Going through testing now and will
push the fix very shortly.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.
Next
From: Jim Nasby
Date:
Subject: Re: more parallel query documentation