Re: pgsql: Improve internationalization of messages involving type names - Mailing list pgsql-committers

From Stephen Frost
Subject Re: pgsql: Improve internationalization of messages involving type names
Date
Msg-id 20160328173558.GU3127@tamriel.snowman.net
Whole thread Raw
In response to pgsql: Improve internationalization of messages involving type names  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-committers
Alvaro,

* Alvaro Herrera (alvherre@alvh.no-ip.org) wrote:
> Improve internationalization of messages involving type names
>
> Change the slightly different variations of the message
>   function FOO must return type BAR
> to a single wording, removing the variability in type name so that they
> all create a single translation entry; since the type name is not to be
> translated, there's no point in it being part of the message anyway.
>
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is.  (I'm not
> quite sure why this is so, but it's the clear majority.)
>
> Some similar messages such as "encoding conversion function FOO must ..."
> are also changed.

Buildfarm is pretty upset with this one, in particular:


http://git.postgresql.org/gitweb/?p=postgresql.git;a=blobdiff;f=src/backend/commands/event_trigger.c;h=3735d44ee9d0b89f35ca8e8fb00b1a8dbbaa6362;hp=3f52ad836b4a2be1d95047f0949607d8cbbb283d;hb=59a2111;hpb=559e7a0a6d4450c09825055e3d255d30ee869c67

Thanks!

Stephen

Attachment

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix minor leak in pg_dump for ACCESS METHOD.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: pg_rewind: Improve internationalization