Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Date
Msg-id 20160325183627.328f7714@fujitsu
Whole thread Raw
In response to Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> In short: the error in Aleksander's argument is the assumption that
> shared hashtables have fixed size.  That's simply false.

Well this is a bit embarrassing but I have to admit that you are right.
Dynahash code is a bit non-trivial to say the least (let me guess -
there is no point of suggesting a patch that splits it into two or
three separate implementations for each use case, right? :) and I
misunderstood how it actually works. My apologies.

-- 
Best regards,
Aleksander Alekseev
http://eax.me/



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: multivariate statistics v14
Next
From: David Steele
Date:
Subject: Re: [PATCH] Phrase search ported to 9.6