Re: pgsql: Move each SLRU's lwlocks to a separate tranche. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Move each SLRU's lwlocks to a separate tranche.
Date
Msg-id 20160325070506.56i5p7jzxwqfljm6@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Move each SLRU's lwlocks to a separate tranche.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Move each SLRU's lwlocks to a separate tranche.
List pgsql-committers
On 2015-11-12 19:59:54 +0000, Robert Haas wrote:
> Move each SLRU's lwlocks to a separate tranche.
>
> This makes it significantly easier to identify these lwlocks in
> LWLOCK_STATS or Trace_lwlocks output.  It's also arguably better
> from a modularity standpoint, since lwlock.c no longer needs to
> know anything about the LWLock needs of the higher-level SLRU
> facility.
>
> Ildus Kurbangaliev, reviewd by Álvaro Herrera and by me.

Before this commit the lwlocks were cacheline aligned, but that's not
the case anymore afterwards; afaics. I think that should be fixed? I
guess it'd be good to avoid duplicating the code for aligning, so maybe
we ought to add a ShmemAllocAligned or something?

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Link libpq after libpgfeutils to satisfy Windows linker.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Move each SLRU's lwlocks to a separate tranche.