Re: WIP: Access method extendability - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: WIP: Access method extendability
Date
Msg-id 20160324010609.GA643244@alvherre.pgsql
Whole thread Raw
In response to Re: WIP: Access method extendability  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: WIP: Access method extendability  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
I don't quite see how this is supposed to work:

+ #ifdef WAL_DEBUG
+   /*
+    * If xlog debug is enabled then check produced delta.  Result of delta
+    * application to saved image should be the same as current page state.
+    */
+   if (XLOG_DEBUG)
+   {
+       char    tmp[BLCKSZ];
+       memcpy(tmp, image, BLCKSZ);
+       applyPageRedo(tmp, pageData->data, pageData->dataLen);
+       elog(ERROR, "result of generic xlog apply doesn't match");
+   }
+ #endif

I suppose the elog(ERROR) call should be conditional ...

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Postgres_fdw join pushdown - getting server crash in left outer join of three table
Next
From: Amit Kapila
Date:
Subject: Re: Relation extension scalability