Re: OOM in libpq and infinite loop with getCopyStart() - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: OOM in libpq and infinite loop with getCopyStart()
Date
Msg-id 20160303161859.42f977f8@fujitsu
Whole thread Raw
In response to OOM in libpq and infinite loop with getCopyStart()  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: OOM in libpq and infinite loop with getCopyStart()
List pgsql-hackers
Hello, Michael

I didn't checked your patch in detail yet but here is a thought I would
like to share.

In my experience usually it takes number of rewrites before patch will
be accepted. To make sure that after every rewrite your patch still
solves an issue you described you should probably provide a few test
programs too. If it's possible to make these programs part of regression
tests suite it would be just great.

Without such test programs I personally find it difficult to verify
that your patch fixes something. If such examples are provided your
patch would be much more likely to accepted. "See, this program crashes
everything. Now we apply a patch and everything works! Cool, heh?"

Best regards,
Aleksander



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc
Next
From: Craig Ringer
Date:
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc