Re: TAP / recovery-test fs-level backups, psql enhancements etc - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: TAP / recovery-test fs-level backups, psql enhancements etc
Date
Msg-id 20160301230713.GA394707@alvherre.pgsql
Whole thread Raw
In response to TAP / recovery-test fs-level backups, psql enhancements etc  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: TAP / recovery-test fs-level backups, psql enhancements etc
List pgsql-hackers
Craig Ringer wrote:

> diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
> index 3d11cbb..8c13655 100644
> --- a/src/test/perl/TestLib.pm
> +++ b/src/test/perl/TestLib.pm
> @@ -112,9 +112,11 @@ INIT
>  #
>  sub tempdir
>  {
> +    my ($prefix) = @_;
> +    $prefix = "tmp_test" if (!$prefix);

This should be "unless defined $prefix".  Otherwise if you pass the
string literal "0" as prefix it will be ignored.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Convert pltcl from strings to objects
Next
From: Tom Lane
Date:
Subject: pl/tcl Unicode conversion doesn't actually work?