Re: Confusing with commit time usage in logical decoding - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Confusing with commit time usage in logical decoding
Date
Msg-id 20160301165755.GA356079@alvherre.pgsql
Whole thread Raw
In response to Re: Confusing with commit time usage in logical decoding  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: Confusing with commit time usage in logical decoding
List pgsql-hackers
Artur Zakirov wrote:
> Hello, Andres
> 
> You have introduced a large replication progress tracking infrastructure
> last year. And there is a problem described at the link in the quote below.
> 
> Attached patch fix this issue. Is this patch correct? I will be grateful if
> it is and if it will be committed.

AFAICS this is clearly a bug introduced in 5aa235042:
   /* replay actions of all transaction + subtransactions in order */   ReorderBufferCommit(ctx->reorder, xid,
buf->origptr,buf->endptr,
 
-                       parsed->xact_time);
+                       commit_time, origin_id, origin_lsn);}

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Anastasia Lubennikova
Date:
Subject: Re: WIP: Covering + unique indexes.
Next
From: Konstantin Knizhnik
Date:
Subject: Re: The plan for FDW-based sharding