Re: Add generate_series(date, date) and generate_series(date, date, integer) - Mailing list pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, failed

Everything looks good except for two minor issues:

1) There should be an informative comment for this struct:

+/* Corey BEGIN */
+typedef struct
+{
+    DateADT        current;
+    DateADT        stop;
+    int32        step;
+} generate_series_date_fctx;

2) There's an extra linefeed after the struct.  Needed?

Regards,
-David

The new status of this patch is: Waiting on Author