Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h - Mailing list pgsql-bugs

From Michael Meskes
Subject Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h
Date
Msg-id 20160201121030.GA18459@feivel
Whole thread Raw
In response to Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Mon, Feb 01, 2016 at 10:56:44AM +0100, Tom Lane wrote:
> It seems a bit fishy that the comment in question starts on an #if line
> and ends on an ordinary line.  I am not sure what the C standard says
> about such cases, but I can certainly imagine that some tools might not
> be very happy with that.

It turns out ecpg is one of these tools. Lines starting with #<whatever> are
considered CPP code and not parsed for C language comments. In the C code it
then finds only the end of the comment and throws the error.

It does surprise me, though, that the error only pops up now. I was pretty sure
at least one of these headers was used in the regression suit.

Will fix.

Thanks.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

pgsql-bugs by date:

Previous
From: Michael Meskes
Date:
Subject: Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h
Next
From: Michael Meskes
Date:
Subject: Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h