Postgres Pro
Downloads
Home   >   mailing lists

Re: Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses
Date
Msg-id 20160107154151.GA425701@alvherre.pgsql
Whole thread Raw
In response to Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Tree view 
Peter Geoghegan wrote:
> We lack SortSupport for many character-like-type cases. In full, the
> cases within the core system are:

You're stealthily introducing a new abstraction called "string",
including a typedef and DatumGetString support macros.  Is that really
necessary?  Shouldn't it be discussed specifically?  I don't necessarily
oppose it as is, mainly because it's limited to within varlena.c for
now, but I'm not sure it'd okay to make it more public.

Also, there's a lot of churn in this patch to just remove tss to sss.
Can't we just keep the original variable name?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Re: Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses
Next
From: Tom Lane
Date:
Subject: Re: Very confusing installcheck behavior with PGXS