Re: Fwd: Core dump with nested CREATE TEMP TABLE - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Fwd: Core dump with nested CREATE TEMP TABLE
Date
Msg-id 20160102005542.GA2951035@tornado.leadboat.com
Whole thread Raw
In response to Re: Fwd: Core dump with nested CREATE TEMP TABLE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fwd: Core dump with nested CREATE TEMP TABLE  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Sep 03, 2015 at 11:04:11PM -0400, Tom Lane wrote:
> *************** AtSubAbort_Portals(SubTransactionId mySu

> --- 909,966 ----
>       {
>           Portal        portal = hentry->portal;
>   
> +         /* Was it created in this subtransaction? */
>           if (portal->createSubid != mySubid)
> +         {
> +             /* No, but maybe it was used in this subtransaction? */
> +             if (portal->activeSubid == mySubid)
> +             {
...
> +                 if (portal->status == PORTAL_ACTIVE)
> +                     MarkPortalFailed(portal);

Do you have a test case that reaches this particular MarkPortalFailed() call?
My attempts stumbled over the fact that, before we reach here, each of the
three MarkPortalActive() callers will have already called MarkPortalFailed()
in its PG_CATCH block.  ("make check" does not reach this call.)



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: WIP: Failover Slots
Next
From: Noah Misch
Date:
Subject: Re: buffer README is out of date