Re: Patch to show individual statement latencies in pgbench output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to show individual statement latencies in pgbench output
Date
Msg-id 2016.1281635333@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to show individual statement latencies in pgbench output  (Greg Smith <greg@2ndquadrant.com>)
Responses Re: Patch to show individual statement latencies in pgbench output  (Florian Pflug <fgp@phlo.org>)
List pgsql-hackers
Greg Smith <greg@2ndquadrant.com> writes:
> Florian Pflug wrote:
>> Attached is an updated version (v4).

> I've attached a v5.  No real code changes from Florian's version, just 
> some wording/style fixes and rework on the documentation.

I'm looking through this patch now.  It looks mostly good, but I am
wondering just exactly what is the rationale for adding comment
statements to the data structures, rather than ignoring them as before.
It seems like a complete waste of logic, memory space, and cycles;
moreover it renders the documentation's statement that comments
"are ignored" incorrect.  I did not find anything in the patch history
explaining the point of that change.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Bozena Potempa"
Date:
Subject: Re: Libpq: PQftype, PQfsize
Next
From: Pavel Stehule
Date:
Subject: Re: review: xml_is_well_formed